Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: make partialDeepStrictEqual work with urls and File prototypes #56231

Merged
merged 1 commit into from
Jan 9, 2025
Merged

assert: make partialDeepStrictEqual work with urls and File prototypes #56231

merged 1 commit into from
Jan 9, 2025

Conversation

puskin94
Copy link
Contributor

this PR should close the gap between assert.deepStrictEqual and assert.partialDeepStrictEqual even more.

Found a couple more cases that were not properly working:

  • URLs were not properly compared
  • it was not passing when comparing Object.getPrototypeOf(File.prototype) and Blob.prototype
  • new Float32Array([+0.0]) and new Float32Array([-0.0]) were considered equal, which is not the case

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. needs-ci PRs that need a full CI run. labels Dec 11, 2024
@BridgeAR BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 11, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64010/

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.56%. Comparing base (9ec8b9e) to head (6b649a7).
Report is 156 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56231      +/-   ##
==========================================
+ Coverage   88.54%   88.56%   +0.02%     
==========================================
  Files         657      657              
  Lines      189899   190663     +764     
  Branches    36465    36593     +128     
==========================================
+ Hits       168140   168859     +719     
- Misses      14966    14995      +29     
- Partials     6793     6809      +16
Files with missing lines Coverage Δ
lib/assert.js 99.37% <100.00%> (+<0.01%) ⬆️

... and 74 files with indirect coverage changes

@puskin94 puskin94 force-pushed the partial-deep-strict-equal-missing-cases branch from 40e6cba to 943cb6d Compare December 11, 2024 20:20
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64144/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64157/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64158/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64162/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64159/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64160/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64164/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64166/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64163/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64165/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64161/

@meixg
Copy link
Member

meixg commented Dec 23, 2024

Sorry I seem to have accidentally clicked it multiple times.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64209/

@puskin94 puskin94 force-pushed the partial-deep-strict-equal-missing-cases branch from 943cb6d to 6b649a7 Compare December 25, 2024 21:58
@BridgeAR BridgeAR added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64409/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64417/

@pmarchini pmarchini added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 9, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 9, 2025
@nodejs-github-bot nodejs-github-bot merged commit 24ed8da into nodejs:main Jan 9, 2025
61 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 24ed8da

targos pushed a commit that referenced this pull request Jan 13, 2025
@puskin94 @targos
assert: make partialDeepStrictEqual work with urls and File prototypes
d1fce7e 
PR-URL: #56231
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jan 13, 2025
@puskin94 @Ceres6
assert: make partialDeepStrictEqual work with urls and File prototypes
d318bed 
PR-URL: nodejs#56231
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonivj5 tonivj5 tonivj5 left review comments

@pmarchini pmarchini pmarchini approved these changes

@meixg meixg meixg approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@puskin94 @nodejs-github-bot @meixg @jasnell @tonivj5 @BridgeAR @pmarchini